Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ikea_e1744.yaml (remove spaces to match new helper events in 2023.5) #548

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rubinho76
Copy link

@rubinho76 rubinho76 commented May 8, 2023

Adaptation to new HA version 2023.5.0 and higher

Thank you for taking the time to work on a Pull Request. Your contribution is really appreciated! 🎉
Please don't delete any part of the template, since keeping the provided structure will help maintainers to review your work more rapidly.

Sections marked as * are required and need to be filled in.

Breaking change

If your PR contains a breaking change for existing users, it is important to describe what breaks, how to make it work again and why we did this. This section will be used to craft the changelog entry, after your PR gets approved and merged.

Note: Remove this section if this PR is NOT a breaking change.

Proposed change*

Describe the big picture of your changes here, and why your pull request should be accepted. If it fixes a bug or resolves a feature request, be sure to put closes #XXXX in this section to auto-close relevant issues.

Please note that for important and breaking changes it's always better to open an issue first for discussing the proposal.

Make sure to provide enough information so that your pull request can be reviewed.

Checklist*

  • I followed sections of the Contribution Guidelines relevant to changes I'm proposing.
  • I properly tested proposed changes on my system and confirm that they are working as expected.
  • I formatted files with Prettier using the command npm run format before submitting my Pull Request.

Adaptation to new HA version 2023.5.0 and higher
@github-actions
Copy link
Contributor

github-actions bot commented May 8, 2023

Hey @rubinho76, thank you so much for your contribution! 🚀

🔄 We're currently running a few checks to make sure that everything is great with your contribution.
If further actions need to be performed before your contribution can be reviewed, additional guidance will be provided to you in the next comment.

Results are coming soon, stay tuned!

@rubinho76 rubinho76 changed the title Update ikea_e1744.yaml Update ikea_e1744.yaml (remove spaces to match new helper events in 2023.5) May 8, 2023
@anders3408
Copy link

This also fixes ikea_e2001_e2002.yaml if that's changed in line 406 and 407

@thomas-svrts
Copy link

Can you update regex to
regex_match("^{(("a":.*|"t":\d+.\d+)(,)?){2}}$")

@FallenLeave91
Copy link

Works for me with zigbee2mqtt on 2023.5.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants