Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use dynamic imports to reduce bundle #1601

Merged
merged 2 commits into from
Mar 11, 2025

Conversation

silvester-pari
Copy link
Collaborator

@silvester-pari silvester-pari commented Mar 11, 2025

Implemented changes

This PR makes use of the dynamic import functionality in ace editor (for modes, themes etc.) in order to reduce the amount of output bundle files. This brings the number of files in the dist folder from 478 back down to 2.

Fixes #1588.

Checklist before requesting a review

Copy link

netlify bot commented Mar 11, 2025

Deploy Preview for eoxelements ready!

Name Link
🔨 Latest commit 5aeff65
🔍 Latest deploy log https://app.netlify.com/sites/eoxelements/deploys/67cfd34f0a5c3c00071f6aa2
😎 Deploy Preview https://deploy-preview-1601--eoxelements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@silvester-pari silvester-pari marked this pull request as ready for review March 11, 2025 06:09
Copy link
Collaborator

@A-Behairi A-Behairi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It builds as expected now 👍🏾, Thank you for the fix!

@silvester-pari silvester-pari merged commit e0218bd into main Mar 11, 2025
8 checks passed
@silvester-pari silvester-pari deleted the jsonform/fix/dynamic-module-import branch March 11, 2025 15:18
@github-actions github-actions bot mentioned this pull request Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inclusion of ace editor creates huge set of bundle files
2 participants