fix: add timestamp to preid #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for eoxelements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
silvester-pari
requested changes
Jul 18, 2024
.github/workflows/dev-release.yml
Outdated
| npm version prerelease --preid ${{ inputs.preid }} && \ | ||
| npm publish --access=public --tag ${{ inputs.preid }} | ||
| npm version prerelease --preid ${{ inputs.preid }}.${{ steps.timestamp.outputs.timestamp }} && \ | ||
| npm publish --access=public --tag ${{ inputs.preid }}.${{ steps.timestamp.outputs.timestamp }} |
There was a problem hiding this comment.
Thanks! I guess in the tag we don't need it, as the tag should ideally always be dev (or something else, like beta, or pr to indicate that it comes from a PR etc.)
See example from openlayers:
silvester-pari
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented changes
automatically adding a time stamp to every dev release preid
Screenshots/Videos
Checklist before requesting a review