This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
rentbw - develop #421
Open
rentbw - develop #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lect the change in rentbw_config_resource
…dvantage to very small rentals under particular situations (but still under the condition of utilization >= adjusted_utilization) Also add calculated fee to the error message when it exceeds max_payment.
… are resonable dependent heavily on the attributes of the core token
…en under the scenario of utilization <= adjusted_utilization
…hould preserve the existing value (or use default when appropriate)
…pricing model to now also include a min_price Note: Assuming min_price is 0, this new price model can be directly compared to the prior one. In fact, under that condition, max_price can be thought of as target_price * exponent.
|
@tbfleming Can we close this PR in favor of your new resource model? Please add a comment here. Thanks |
|
They supplement each other. |
|
This PR is the develop version of the rentbw-1.9 branch that the community is currently evaluating. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Ports #397 to
develop.Deployment Changes
See "Deployment Changes" of #397.
API Changes
See "API Changes" of #397.
Documentation Additions
See description in #397.