Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Empty toast error #293

Closed
wants to merge 3 commits into from
Closed

[Bug] Empty toast error #293

wants to merge 3 commits into from

Conversation

kunal00000
Copy link
Contributor

Issue Number

fixes #201

Describe the changes you've made

Describe if there is any unusual behavior (Any Warning) of your code(Write NA if there isn't)

Additional context (OPTIONAL)
Screenshot 2022-12-31 at 6 56 22 PM

Test plan (OPTIONAL)

A good test plan should give instructions that someone else can easily follow.

Checklist

  • [x ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • [x ] The title of my pull request is a short description of the requested changes.

Provide a Deployed link of route/page that needs to review

Preview: Deploy preview link here with the appropriate route

@kailash360
Copy link
Member

This explains only the error type in the toast box. We also need to show the error message or a one-line explanation of the error.

@kunal00000
Copy link
Contributor Author

kunal00000 commented Jan 8, 2023

@kailash360
Okay working on this but I am not able to figure out that why only on keeping description empty, it gives error response and toast. When all the fields are empty it does not give toast and response
I didn't know about useForm, I checked it now only. Is it stopping the submission of form hence not resulting in error when apart from description, more fields are empty.

@kunal00000
Copy link
Contributor Author

@kailash360 review if this works

If description would be empty it would generate error like this.

Screenshot 2023-01-12 at 2 51 15 AM

If any other error persists it would generate like below.

Screenshot 2023-01-12 at 2 49 57 AM

I have tried several cases and getting error only when description is empty. On submit if Title Product Category Priority are empty, form is not submitted until all these are given value.

Copy link
Member

@kailash360 kailash360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kunal00000
Copy link
Contributor Author

@kailash360 I have made some changes.
If description is empty, it will not run try and catch rather directly show error.

@kunal00000 kunal00000 closed this by deleting the head repository May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error toast notification shows only 'X' icon with no message.
2 participants