Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: #9: Added New feature to download multiple animated icons #58

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fixed: #9: Added New feature to download multiple animated icons #58

wants to merge 4 commits into from

Conversation

chinmaym07
Copy link
Contributor

fixes: #9

Peek.2022-02-22.04-18.mp4

Signed-off-by: chinmaym07 [email protected]

cyntss
cyntss reviewed Feb 22, 2022
View reviewed changes
src/components/Tabs.js Outdated
@@ -18,33 +18,34 @@ const Tabs = (props) => {

const [activeTab, setActiveTab] = useState(currentTab)
const [checked, setChecked] = useState(false)
const [staticCheck, setStaticCheck] = useState(false)
/* const [staticCheck, setStaticCheck] = useState(false) */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never comment out old code. Simply remove it if it isn't necessary any longer.

@kaybhutani
Copy link
Member

@chinmaym07 we have to remove the font button for animated icons as it won't be supported. Can you double check that with the API? Is it working as expected?

@cyntss
Copy link
Member

cyntss commented Mar 22, 2022

@chinmaym07 please let us know when you remove the font button so we can merge this PR

@kaybhutani
Copy link
Member

@chinmaym07 can you resolve conflicts?

@chinmaym07 chinmaym07 force-pushed the new-download-multiple-icons branch from a888157 to 1e9fc4a Compare July 3, 2022 10:14
@chinmaym07
Resolved the build issue
197cfb5 
Signed-off-by: chinmaym07 <[email protected]>
@chinmaym07
Copy link
Contributor Author

Hey @kbhutani0001 I have removed the font button for animated icons as well as there is a small issue when we are in multiple select mode & we double click on any other icon it opens the iconEditor with empty icon.
I disabled the doubleClickAction for now but we can do another thing like if we are in multiple select mode we can do something similar to if we click on image button.

Please review!!

Peek.2022-07-03.15-53.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyntss cyntss cyntss left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Feature : Adding option for downloading multiple animated icons
3 participants
@chinmaym07 @kaybhutani @cyntss