Skip to content

chore/cleanup #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 7, 2025
Merged

chore/cleanup #63

merged 5 commits into from
Nov 7, 2025
+7 −54

Conversation

@d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Nov 6, 2025

Simplify a test by using a pytest built-in temporary path fixture, and remove a function that is never used.

@d-v-b d-v-b requested a review from emmanuelmathot November 6, 2025 14:14
@d-v-b
Copy link
Contributor Author

d-v-b commented Nov 6, 2025

only pre-commit is failing, which is baseline. I think this is good to go @emmanuelmathot

emmanuelmathot
emmanuelmathot approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@emmanuelmathot emmanuelmathot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@d-v-b d-v-b merged commit 2275535 into EOPF-Explorer:main Nov 7, 2025
6 checks passed
@d-v-b d-v-b deleted the chore/cleanup branch November 7, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emmanuelmathot emmanuelmathot emmanuelmathot approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@d-v-b @emmanuelmathot