Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create service accounts in EGI Check-in #664

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

sebastian-luna-valero
Copy link
Member

@sebastian-luna-valero sebastian-luna-valero commented Jul 22, 2024

Summary

Add a page on how to create service accounts, following discussion via:
https://ggus.eu/?mode=ticket_info&ticket_id=161888#update#10


Related issue :
Business Requirement: EGIREQ-156

@sebastian-luna-valero sebastian-luna-valero added the safe for preview Pull request vetted as safe for preview label Jul 22, 2024

This comment has been minimized.

Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/664

Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/664

Copy link
Member

@brucellino brucellino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provide some context of who would want a service account, what it's used for typically.

description: >
Create a Service Account using EGI Check-in
---

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would first describe what a service account is and why it would be used.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just added a brief intro, please check

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks better! We still leave too much room for confusion though. We should provide specific scenarios - a concrete example (maybe the one in the business requirement).

Copy link

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/664

@vardizzo-lab
Copy link

This PR is related to the request tracked inthe ticket EGIREQ-156 and will follow the evaluation and resolution process.
Current github users enabled in the role of reviewers are kindly asked not to continue with the publication process until the end of jira ticket workflow.

@brucellino
Copy link
Member

@sebastian-luna-valero Can we put this into draft while we're still reviewing it just to avoid accidentally merging?

description: >
Create a Service Account using EGI Check-in
---

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks better! We still leave too much room for confusion though. We should provide specific scenarios - a concrete example (maybe the one in the business requirement).

description: >
Create a Service Account using EGI Check-in
---

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently a deprecated feature. We can document it, but it should explicitly be annotated as deprecated since we do not support it in general availability. @sebastian-luna-valero can you see if there is a Docusaurus feature which allows us to add such a warning or admonition to make it clear to readers that this feature is deprecated and unsupported?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we better wait for the resolution of EGIREQ-156 to move forward? If the feature is deprecated and unsupported, and the plan is to stop there, I would not even add this new page.

@sebastian-luna-valero sebastian-luna-valero marked this pull request as draft August 5, 2024 13:39
Copy link

github-actions bot commented Jan 9, 2025

🦙 MegaLinter status: ⚠️ WARNING

Descriptor Linter Files Fixed Errors Elapsed time
✅ EDITORCONFIG editorconfig-checker 3 0 0.01s
⚠️ MARKDOWN markdownlint 2 1 0.27s
✅ MARKDOWN markdown-link-check 2 0 10.2s
✅ MARKDOWN markdown-table-formatter 2 0 0.21s
✅ REPOSITORY checkov yes no 16.25s
✅ REPOSITORY gitleaks yes no 0.06s
✅ REPOSITORY git_diff yes no 0.05s
✅ REPOSITORY secretlint yes no 2.71s
✅ REPOSITORY trivy-sbom yes no 0.24s
✅ SPELL lychee 3 0 2.58s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Jan 9, 2025

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/664

@gwarf gwarf removed the safe for preview Pull request vetted as safe for preview label Jan 9, 2025
@gwarf gwarf added the safe for preview Pull request vetted as safe for preview label Jan 9, 2025
Copy link

github-actions bot commented Jan 9, 2025

Documentation preview deployed!

Available at https://docs.egi.eu/documentation/664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe for preview Pull request vetted as safe for preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants