update docstring for assign_tasks_per_compute_unit and add check#336
Merged
Conversation
casparvl
reviewed
May 6, 2026
Co-authored-by: Caspar van Leeuwen <33718780+casparvl@users.noreply.github.com>
casparvl
approved these changes
May 6, 2026
Collaborator
casparvl
left a comment
There was a problem hiding this comment.
Looks good to me. Small test case shows nothing is broken:
$ reframe -c test-suite/eessi/testsuite/tests/apps/gromacs.py --run -t CI -t 1_8_node --system snellius:rome
/gpfs/home4/casparl/EESSI/eessi_test_venv/lib64/python3.9/site-packages/setuptools_scm/_integration/setuptools.py:31: RuntimeWarning:
ERROR: setuptools==53.0.0 is used in combination with setuptools_scm>=8.x
Your build configuration is incomplete and previously worked by accident!
setuptools_scm requires setuptools>=61
Suggested workaround if applicable:
- migrating from the deprecated setup_requires mechanism to pep517/518
and using a pyproject.toml to declare build dependencies
which are reliably pre-installed before running the build tools
warnings.warn(
[ReFrame Setup]
version: 4.10.0-dev.0+04f8df5a
command: '/gpfs/home4/casparl/EESSI/eessi_test_venv/bin/reframe -c test-suite/eessi/testsuite/tests/apps/gromacs.py --run -t CI -t 1_8_node --system snellius:rome'
launched by: casparl@tcn317.local.snellius.surf.nl
working directory: '/gpfs/home4/casparl/EESSI'
settings files: '<builtin>', '/gpfs/home4/casparl/EESSI/test-suite/config/surf_snellius.py'
selected system: 'snellius'
check search path: (R) '/gpfs/home4/casparl/EESSI/test-suite/eessi/testsuite/tests/apps/gromacs.py'
stage directory: '/scratch-shared/casparl/reframe_output/staging'
output directory: '/gpfs/home4/casparl/EESSI/reframe_runs/output'
log files: '/gpfs/home4/casparl/EESSI/reframe_runs/logs/reframe_20260506_131801.log'
results database: [off] '/home/casparl/.reframe/reports/results.db'
== Temporary log file in case of crash /scratch-local/casparl.22483237/eb-splau28r/easybuild-qw0fd5jp.log
[==========] Running 2 check(s)
[==========] Started on Wed May 6 13:18:04 2026+0200
[----------] start processing checks
[ RUN ] EESSI_GROMACS %benchmark_info=HECBioSim/Crambin %nb_impl=cpu %scale=1_8_node %module_name=GROMACS/2025.2-foss-2025a /d39a9259 @snellius:rome+default
[ RUN ] EESSI_GROMACS %benchmark_info=HECBioSim/Crambin %nb_impl=cpu %scale=1_8_node %module_name=GROMACS/2025.4-foss-2025b /be7d4945 @snellius:rome+default
[ OK ] (1/2) EESSI_GROMACS %benchmark_info=HECBioSim/Crambin %nb_impl=cpu %scale=1_8_node %module_name=GROMACS/2025.4-foss-2025b /be7d4945 @snellius:rome+default
P: perf: 77.097 ns/day
[ OK ] (2/2) EESSI_GROMACS %benchmark_info=HECBioSim/Crambin %nb_impl=cpu %scale=1_8_node %module_name=GROMACS/2025.2-foss-2025a /d39a9259 @snellius:rome+default
P: perf: 78.094 ns/day
[----------] all spawned checks have finished
[ PASSED ] Ran 2/2 test case(s) from 2 check(s) (0 failure(s), 0 expected failure(s), 0 skipped, 0 aborted)
[==========] Finished on Wed May 6 13:20:45 2026+0200
Log file(s) saved in '/gpfs/home4/casparl/EESSI/reframe_runs/logs/reframe_20260506_131801.log'
Approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #330