-
Notifications
You must be signed in to change notification settings - Fork 64
{2023.06}[foss/2023b] Flux 0.76.0 #1107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ocaisa
wants to merge
33
commits into
EESSI:main
Choose a base branch
from
ocaisa:flux
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
2e8b6eb
{2023.06}[foss/2023b] Flux 0.74.0
ocaisa ebf2c0f
Commit did not include patch
ocaisa be3f924
Test from-pr to see if that picks up the patch
ocaisa c4c4eab
Revert now patches are in the right place
ocaisa 1ed7a44
Update eessi-2023.06-eb-5.1.0-2023b.yml
ocaisa e475655
Try with patch in two places
ocaisa 2292a2a
Merge branch 'flux' of github.com:ocaisa/software-layer into flux
ocaisa 1aa6823
Add fix for Zen4
ocaisa dfe0360
Another try
ocaisa 5e52ad3
Try again
ocaisa 88b2f9a
Merge branch 'main' into flux
ocaisa fb4da8b
Update eessi-2023.06-eb-5.1.0-2023b.yml
ocaisa 8a69308
Update eessi-2023.06-eb-5.1.0-2023b.yml
ocaisa 477d5ee
Update eessi-2023.06-eb-5.1.0-2023b.yml
ocaisa 9357b09
Merge branch 'main' into flux
ocaisa ee65402
Merge branch 'main' into flux
ocaisa eb88a1c
Update eb version for Flux build
ocaisa 0fad31b
Merge branch 'flux' of github.com:ocaisa/software-layer into flux
ocaisa 7dddb88
Fix syntax and correct Flux version
ocaisa 4ebd6c7
Update eessi-2023.06-eb-5.1.1-2023b.yml
ocaisa 0526838
Update eessi-2023.06-eb-5.1.1-2023b.yml
ocaisa 6a95cbd
Update eessi-2023.06-eb-5.1.1-2023b.yml
ocaisa 9652743
Update eessi-2023.06-eb-5.1.1-2023b.yml
ocaisa 86742bf
Merge branch 'main' into flux
ocaisa a70f999
Update eessi-2023.06-eb-5.1.1-2023b.yml
ocaisa 22b1c59
Update eessi-2023.06-eb-5.1.1-2023b.yml
ocaisa 0cdb8ee
Random issues seen for some archs, build in RAM
ocaisa 505a3ce
Merge branch 'flux' of github.com:ocaisa/software-layer into flux
ocaisa e8f4a02
Merge branch 'main' into flux
ocaisa ccf6d41
Use merge commit from EB, build in /dev/shm
ocaisa 3255bbc
Merge remote-tracking branch 'upstream/main' into flux
ocaisa d505f4c
Ignore test failures for Flux as we seem to have some issues with our…
ocaisa 141a34f
Make sure easystack has valid syntax
ocaisa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
12 changes: 12 additions & 0 deletions
12
easystacks/software.eessi.io/2023.06/eessi-2023.06-eb-5.1.1-2023b.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,15 @@ | ||
| easyconfigs: | ||
| - openCARP-17.0-foss-2023b.eb | ||
| - libheif-1.19.5-GCCcore-13.2.0.eb | ||
| - Flux-0.76.0-GCC-13.2.0.eb: | ||
| options: | ||
| # see https://github.com/easybuilders/easybuild-easyconfigs/pull/22979 | ||
| from-commit: 856e35188b9ec014cc8f95e13044e14e5d7463f9 | ||
| # for some still unknown reason sapphaire rapids on the build cluster | ||
| # is extremely slow and causes the test suite to time out. | ||
| # The builds have been tested a hundred times via | ||
| # https://github.com/EESSI/software-layer/pull/1107 | ||
| # and passes for every architecture except sapphaire rapids. Building | ||
| # interactively on that arch with EESSI-extend does work so we just | ||
| # ignore test failures to get this build ingested. | ||
| ignore-test-failure: True | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While this is indeed being picked up, I'm not sure it will have the desired effect as I don't know if it will get passed through to the extensions, I guess we will find out...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're talking Python packages as extensions, it should.
install_extensioninPythonPackageeasyblock calls_test_step(nottest_step), which corresponds to theEasyBlock._test_stepmethod which takes into account theignore_test_failurebuild optionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this only applies to Sapphire Rapids, I'm wondering if we should do this more selectively in the EasyBuild hooks instead, but maybe it's not really worth the effort...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have said components not extensions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, indeed, in
Bundleeasyblock we're callingcomp.test_step, we should be callingcomp._test_stepto make it aware ofignore_test_failure.And may we should reconsider the naming in
EasyBlock, so calling out totest_stepensures thatignore_test_failureis taken into account...