Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI rewrite in wxPython #2239

Closed
wants to merge 12 commits into from
Closed

UI rewrite in wxPython #2239

wants to merge 12 commits into from

Conversation

ElSaico
Copy link
Contributor

@ElSaico ElSaico commented May 25, 2024

Description

This rips off the current Tkinter UI and replaces it with a wxPython implementation. Some points on its favor:

  • Much better documentation
  • A rich library of widgets (see above)
  • Handles most of the platform-dependant stuff, while exceptions are documented
  • Both APIs are similar enough to make the inevitable rewrite of the plugins' UI code easier
  • Built-in i18n support via gettext, eliminating the need for l10n.py - and allowing the use of tools such as Poedit
  • A single approach to theming, instead of the current kludge to support non-ttk widgets
  • Tools like wxFormBuilder, which even generates Python code, can be used as a visual aid

Example Images

TBA

Type of Change

A rather large rewrite.

How Tested

TBA

Notes

wxPython's Config is remarkably similar to ours, down to the use of registry on Windows and INI files on Linux.
This could mean even less code to maintain on EDMC's side, but its lack of a get_list equivalent impedes a direct port.

@ElSaico
Copy link
Contributor Author

ElSaico commented May 28, 2024

Closing this as a practical approach to ttk themes was found on #2241.

@ElSaico ElSaico closed this May 28, 2024
@ElSaico ElSaico deleted the wxedmc branch June 9, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant