Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2d neighbors #755

Open
wants to merge 38 commits into
base: master
Choose a base branch
from
Open

2d neighbors #755

wants to merge 38 commits into from

Conversation

streeve
Copy link
Member

@streeve streeve commented May 14, 2024

Enable 2d neighbor construction and iteration. Dimension extracted from particle data in creation functions with default 3d template dimension in classes for backwards compatibility

Other notes:

  • ArborX does not support 2d as far as I can tell
  • New VerletList creation functions
  • Adds new discriminator for LinkedCellList

Part of #490

@streeve streeve self-assigned this May 14, 2024
@streeve streeve force-pushed the 2d_neighbors branch 5 times, most recently from 4ca30da to ec1acc4 Compare May 17, 2024 19:30
@streeve
Copy link
Member Author

streeve commented May 17, 2024

Ok @lebuller this is ready for review. Looking into a good way to do the ArborX lists and planning to add 2d tests, but otherwise ready.

Also probably good to move those last two commits to a separate PR if you agree

@streeve streeve requested a review from lebuller May 20, 2024 15:01
@aprokop
Copy link
Contributor

aprokop commented May 20, 2024

Ok @lebuller this is ready for review. Looking into a good way to do the ArborX lists and planning to add 2d tests, but otherwise ready.

What do you mean by "good way to do the ArborX lists"?

@streeve streeve force-pushed the 2d_neighbors branch 2 times, most recently from 6212f87 to f481b33 Compare May 20, 2024 15:44
@streeve
Copy link
Member Author

streeve commented May 20, 2024

What do you mean by "good way to do the ArborX lists"?

Haven't tried yet, but I'd like to extract the dimension from the positions directly. Which would be nice across all cases honestly

@lebuller
Copy link
Collaborator

Looks mostly good to me, we should probably add tests of the 2D list capabilities as well which don't seem to be included

@streeve
Copy link
Member Author

streeve commented Oct 14, 2024

@lebuller ready for another review - the new creation functions extract the dimension from the particles directly. You could still explicitly construct an object if those don't match if necessary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants