[WIP] Collective Effects Config in Dashboard #690
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proy30
added
component: dashboard
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/python/impactx/dashboard/Input/space_charge_configuration/spaceChargeFunctions.py
Fixed
Show resolved
Hide resolved
|
UI as of 9/4/24 - 6:25pm PST:
|
ax3l
reviewed
Sep 5, 2024
Comment on lines
+21
to
+26
| try: | ||
| prob_relative_value = float(prob_relative_value) | ||
| poisson_solver = state.poisson_solver | ||
|
|
||
| if poisson_solver == "multigrid": |
|
|
||
| state.dynamic_size = False | ||
| state.max_level = 3 | ||
| state.n_cell = [0.0, 0.0, 0.0] |
There was a problem hiding this comment.
n_cell are integers.
Validation: they MUST be >1 if space charge (any solver) is on.
A sensible, coarse default is:
Suggested change
| state.n_cell = [0.0, 0.0, 0.0] | |
| state.n_cell = [32, 32, 32] |
src/python/impactx/dashboard/Input/space_charge_configuration/spaceChargeMain.py
Outdated
Show resolved
Hide resolved
ax3l
changed the title
|
Accidently pulled in code from unit testing.. need to remove first 18 commits as they are not related to this PR. |
for more information, see https://pre-commit.ci
folder name is still called 'csrConfiguration'
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
This reverts commit 4456665.
proy30
force-pushed
the
dashboard/space_charge_configuration
branch
from
d6d3cb1
to
c08a1be
Compare
for more information, see https://pre-commit.ci
…y30/impactx into dashboard/space_charge_configuration
proy30
commented
Sep 13, 2024
Comment on lines
+44
to
+57
| if state.space_charge: | ||
| sim.max_level = state.max_level | ||
| sim.n_cell = state.n_cell | ||
| sim.particle_shape = state.particle_shape | ||
| sim.poisson_solver = state.poisson_solver | ||
| sim.space_charge = state.space_charge | ||
| sim.dynamic_size = state.dynamic_size | ||
| sim.prob_relative = state.prob_relative | ||
|
|
||
| # csr | ||
| if state.csr: | ||
| sim.csr = state.csr | ||
| sim.csr_bins = state.csr_bins | ||
|
|
There was a problem hiding this comment.
Currently, particle_shape is only displayed when space_charge is set to True. However, I see that particle_shape is also being used in run_chicane_csr.py. Should we consider having particle_shape displayed for CSR as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds in Space Charge and CSR configuration for users.
For Space Charge:
For CSR
Resolves #665