Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MPAS-Analysis ocean conservation from default config #678

Merged

Conversation

xylar
Copy link
Contributor

@xylar xylar commented Feb 5, 2025

We do not plan to run with the conservation check on by default, so it doesn't make sense to have the analysis plots on by default.

Additionally, the v3 reference simulation is outputting conservation at a monthly interval, but MPAS-Analysis assumes it is being output at a daily interval, the new default. Incorrect rolling averages were leading to no data being plotted.

Summary

Objectives:

  • Fix MPAS-Analysis plots of ocean conservation in E3SM-Unified 1.11.0rc5 that are empty (see zppy weekly testing log #634 (reply in thread))
  • Disable ocean conservation plots by default because the required data will not be available in most E3SM v3 simulations.

Select one: This pull request is...

  • a bug fix: increment the patch version
  • a small improvement: increment the minor version
  • a new feature: increment the minor version
  • an incompatible (non-backwards compatible) API change: increment the major version

Small Change

  • To merge, I will use "Squash and merge". That is, this change should be a single commit.
  • Logic: I have visually inspected the entire pull request myself.
  • Pre-commit checks: All the pre-commits checks have passed.

We do not plan to run with the conservation check on by default,
so it doesn't make sense to have the analysis plots on by default.

Additionally, the v3 reference simulation is outputting conservation
at a monthly interval, but MPAS-Analysis assumes it is being
output at a daily interval, the new default.  Incorrect rolling
averages were leading to no data being plotted.
@xylar
Copy link
Contributor Author

xylar commented Feb 5, 2025

@forsyth2, please let me know if this change makes sense to you. I think it should have been included in #659 and it was just an oversight.

@forsyth2
Copy link
Collaborator

forsyth2 commented Feb 5, 2025

Yeah, this makes sense, thanks!

@forsyth2
Copy link
Collaborator

forsyth2 commented Feb 7, 2025

I'll go ahead and merge this, thanks!

@forsyth2 forsyth2 merged commit 046c618 into E3SM-Project:main Feb 7, 2025
5 checks passed
@forsyth2 forsyth2 deleted the fix-mpas-analysis-ocean-conservation branch February 7, 2025 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants