Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow e3sm_to_cmip to use ilamb parameter names #672

Merged
merged 5 commits into from
Mar 6, 2025
+322 −18
Merged

Allow e3sm_to_cmip to use ilamb parameter names #672

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1cf4fa2
Allow e3sm_to_cmip to use ilamb parameter names
forsyth2 Feb 4, 2025
45dc2c6
Test unspecified ts_subsection
forsyth2 Mar 5, 2025
31e2f15
Check for empty component subsection names
forsyth2 Mar 5, 2025
3384fc4
add cmor supported 2d atm variables as default
chengzhuzhang Mar 6, 2025
44992bb
Self-code review
forsyth2 Mar 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Loading
Loading status checks…
Test unspecified ts_subsection
@forsyth2
forsyth2 committed Mar 5, 2025
commit 45dc2c6c77a4ff8eb581e0e6b5f83aff23940476
8 changes: 8 additions & 0 deletions tests/test_zppy_e3sm_to_cmip.py
View file
Original file line number Diff line number Diff line change
@@ -81,6 +81,10 @@ def test_check_and_define_parameters():
check_and_define_parameters(c, sub)
assert c["ts_subsection"] == "name_of_this_subsection"

c = {"guess_section_parameters": True}
check_and_define_parameters(c, sub)
assert c["ts_subsection"] == "name_of_this_subsection"

# Don't guess the subsection
c = {"ts_subsection": "subsection", "guess_section_parameters": False}
check_and_define_parameters(c, sub)
@@ -126,3 +130,7 @@ def test_check_and_define_parameters():
c = {"ts_land_subsection": "land_subsection", "guess_section_parameters": False}
with pytest.raises(ParameterNotProvidedError):
check_and_define_parameters(c, sub)

c = {"guess_section_parameters": False}
with pytest.raises(ParameterNotProvidedError):
check_and_define_parameters(c, sub)