-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fix for checking is_time_series()
property based on data_type
attr
#881
Conversation
- Now checks the `data_type` attr too
is_time_series()
propertyis_time_series()
property based on data_type
attr
if (self.data_type == "ref" and self.parameter.ref_timeseries_input) or ( | ||
self.data_type == "test" and self.parameter.test_timeseries_input | ||
): | ||
return True | ||
else: | ||
return False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more explicit version of the main
code below:
e3sm_diags/e3sm_diags/driver/utils/dataset.py
Lines 188 to 195 in 4cda0a8
def is_timeseries(self): | |
""" | |
Return True if this dataset is for timeseries data. | |
""" | |
if self.ref: | |
return getattr(self.parameters, "ref_timeseries_input", False) | |
else: | |
return getattr(self.parameters, "test_timeseries_input", False) |
@chengzhuzhang This PR should fix the attribute error (tested with your run script). You can rebase your eamxx_1024 branch on the latest EDIT: Actually let me address a few more of the open issues in #871 first so you don't have to keep rebasing. |
@tomvothecoder thank you. I will keep modifying eamxx_1024, the changes are mostly contained within variable derivation, so it is easy to rebase. |
Description
Checklist
If applicable: