Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor]: CDAT Migration Phase 3 - Port changes from main to cdat-migration-fy24 #871

Closed
tomvothecoder opened this issue Oct 21, 2024 · 3 comments

Comments

@tomvothecoder
Copy link
Collaborator

tomvothecoder commented Oct 21, 2024

Is your feature request related to a problem?

Commits from 03-01-23 to 10-31-24

Todo

In Progress

Done

Rebased

800

Other PRs:

Describe the solution you'd like

No response

Describe alternatives you've considered

No response

Additional context

No response

@tomvothecoder tomvothecoder changed the title [Feature]: [Refactor]: CDAT Migration Phase 3 - Add changees from main to cdat-migration-fy24 Oct 21, 2024
@tomvothecoder tomvothecoder changed the title [Refactor]: CDAT Migration Phase 3 - Add changees from main to cdat-migration-fy24 [Refactor]: CDAT Migration Phase 3 - Port changes from main to cdat-migration-fy24 Oct 21, 2024
@tomvothecoder
Copy link
Collaborator Author

tomvothecoder commented Oct 29, 2024

Hey @chengzhuzhang, I just realized we still need to refactor #675 soon because it still uses the Dataset class from dataset.py and some CDAT-based utilities, and we want to remove CDAT dependencies for v0.8.0.

I can start refactoring it and then you can add the feature enhancements afterwards. Let me know your thoughts.

@chengzhuzhang
Copy link
Contributor

I can start refactoring it and then you can add the feature enhancements afterwards. Let me know your thoughts.

@tomvothecoder your plan sounds good to me! Thank you.

@tomvothecoder
Copy link
Collaborator Author

Closed after completion of #883

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants