Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore EKAT nightly testing #6983

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Conversation

jgfouca
Copy link
Member

@jgfouca jgfouca commented Feb 7, 2025

The Jenkins scripts used to enable EKAT testing for nightly runs:

  if [ -n "$PULLREQUESTNUM" ]; then
      is_at_run=1
  else
      TAS_ARGS="${TAS_ARGS} --test-level nightly"
      # We never want to submit a fake run to the dashboard                                                                                                                                                                    
      if [ -z "$SCREAM_FAKE_ONLY" ]; then
          # Run EKAT tests for real nightly runs                                                                                                                                                                               
          TAS_ARGS="${TAS_ARGS} --submit -c EKAT_ENABLE_TESTS=ON"
      fi
  fi

It looks like we also lost the --test-level nightly flag. Looking around eamxx, it looks like the cmake setting SCREAM_TEST_LEVEL is not really used for much, so maybe this is fine for now.

This PR will re-enable EKAT testing for scheduled runs (nightlies). I'd also like to enable them when the EKAT label is present on a PR is present, but that seems to be pretty hard to do in the YAML.

Also, remove trailing whitespace in a few places.

[BFB]

@jgfouca jgfouca added BFB PR leaves answers BFB EAMxx PRs focused on capabilities for EAMxx labels Feb 7, 2025
@jgfouca jgfouca requested review from bartgol, ambrad and mahf708 February 7, 2025 18:43
@jgfouca jgfouca added the CI: workflow change approved Allow testing on ghci-snl-* machines of PRs that alter a worfklow file label Feb 7, 2025
Copy link
Contributor

@bartgol bartgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the best way to get things going, though I may suggest we write a separate workflow file for ekat's testing. The separate workflow can be triggered by PRs if the ekat submodule is modified, and can also take care of nightly testing.

Re: labels. When I first started working on the AT2 yaml files, I did add support for doing different things depending on labels (e.g., to skip some jobs). However, that made the files much more complicated.

bartgol added a commit that referenced this pull request Feb 10, 2025
The Jenkins scripts used to enable EKAT testing for nightly runs:

It looks like we also lost the --test-level nightly flag. Looking around eamxx,
it looks like the cmake setting SCREAM_TEST_LEVEL is not really used for much,
 so maybe this is fine for now.

This PR will re-enable EKAT testing for scheduled runs (nightlies).
I'd also like to enable them when the EKAT label is present on a PR is present,
but that seems to be pretty hard to do in the YAML.

Also, remove trailing whitespace in a few places.

[BFB]
@bartgol bartgol merged commit b335df0 into master Feb 10, 2025
10 checks passed
@bartgol bartgol deleted the jgfouca/restore_ekat_nightlies branch February 10, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB PR leaves answers BFB CI: workflow change approved Allow testing on ghci-snl-* machines of PRs that alter a worfklow file EAMxx PRs focused on capabilities for EAMxx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants