Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct IcoswISC30E3r5 to gis1to10kmR2 mapping file name. #6905

Conversation

stephenprice
Copy link
Contributor

This PR corrects the name of the mapping file between IcoswISC30E3r5 and gis1to10kmR2 in /cime_config/config_grids.xml.

This fix has been tested and confirmed working (fixing a problem where the mapping file was not found upon executing case.submit).

Note that there is currently an inconsistency between the filename used on line no. 5964 of config_grids.xml (Greenland 1to1km init. cond. file) and the related line no. 5839 (Greenland 20km init. cond. file). That should also be rectified as part of this pull request.

Correct name of mapping file between IcoswISC30E3r5 and gis1to10kmR2.
@jonbob
Copy link
Contributor

jonbob commented Feb 3, 2025

@rljacob -- I think we discussed this, but I couldn't find it anywhere. Anyway, we have been committing mapping filenames like:

map_IcoswISC30E3r5_to_gis1to10kmR2_esmfneareststod.20240422.deeperThan300m.nc

but I think we had decided that

map_IcoswISC30E3r5_to_gis1to10kmR2_esmfneareststod.deeperThan300m.20240422.nc

fit our naming convention better. There are only three or four of these files currently, so we would like to pick a naming style and make them all consistent in this PR

@rljacob
Copy link
Member

rljacob commented Feb 3, 2025

What we have in our confluence page is "map_grida_to_gridb_Optionaltext.ToolAlgorithm.YYYYMMDD.nc" so it should be map_IcoswISC30E3r5_to_gis1to10kmR2_deeperThan300m.esmfneareststod.20240422.nc.

@jonbob
Copy link
Contributor

jonbob commented Feb 3, 2025

@rljacob -- just what we needed to know. Thanks

@jonbob
Copy link
Contributor

jonbob commented Feb 4, 2025

Following @rljacob's comment, I made the deeperThan300m mapping file names self-consistent and matching the E3SM naming convention. @stephenprice -- I also changed the MALI resolution in the new mapping file from "gis_1to10km_r02" to "gis1to10kmR2" to match the other mapping files. Please let me know if you want to change it back

@jonbob
Copy link
Contributor

jonbob commented Feb 4, 2025

Copied old filenames to new filenames in the inputdata repo and lcrc local inputdata directory, in order to allow old versions of the code to still find the files

@jonbob
Copy link
Contributor

jonbob commented Feb 5, 2025

Passes:

  • SMS_D_Ld1.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.chrysalis_intel.allactive-wcprod
  • e3sm_landice_developer on chrysalis using gnu, except
    • ERS.ne30pg2_r05_IcoswISC30E3r5_gis20.IGELM_MLI.chrysalis_gnu.mali-gis20km failed due to a CIME issue
      with ERS?
    • SMS.ne30pg2_r05_IcoswISC30E3r5_gis20.BGWCYCL1850.chrysalis_gnu.allactive-gis20km had an expected
      NML DIFF due to new mapping file name

Copy link
Contributor

@jonbob jonbob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on testing and discussion on naming convention

@stephenprice
Copy link
Contributor Author

These changes all look good to me. Thanks Jon and Rob.

jonbob added a commit that referenced this pull request Feb 5, 2025
…me' into next (PR #6905)

Correct IcoswISC30E3r5 to gis1to10kmR2 mapping file name

This PR corrects the name of the mapping file between IcoswISC30E3r5 and
gis1to10kmR2 in cime_config/config_grids.xml. It also makes all
OCN2GLC_TF_SMAPNAME mapping files have names that are self-consistent
and agree with the E3SM naming convention.

[BFB]
@jonbob
Copy link
Contributor

jonbob commented Feb 5, 2025

merged to next

@jonbob jonbob merged commit 9c7a64a into E3SM-Project:master Feb 6, 2025
6 checks passed
@jonbob
Copy link
Contributor

jonbob commented Feb 6, 2025

merged to master and expected NML DIFFs blessed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants