Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds fice initialization to conv_water_init #6858

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Adds fice initialization to conv_water_init #6858

wants to merge 1 commit into from
+9 −4

Conversation

whannah1
Copy link
Contributor

@whannah1 whannah1 commented Dec 17, 2024 •
edited by mahf708
Loading

Add initialization of the "fice" pbuf variable within conv_water_init to avoid debug mode failure when shr_infnan_isnan is called.

Fixes #6179.

[BFB]

@whannah1 whannah1 requested a review from ndkeen December 17, 2024 22:32
@github-actions GitHub Actions
Copy link

PR Preview Action v1.4.8
🚀 Deployed preview to https://E3SM-Project.github.io/E3SM/pr-preview/pr-6858/
on branch gh-pages at 2024-12-17 22:35 UTC

@ndkeen ndkeen mentioned this pull request Dec 18, 2024
Open
@whannah1
Copy link
Contributor Author

e3sm_atm_developer passes on chrysalis

@ndkeen
Copy link
Contributor

ndkeen commented Dec 19, 2024

I ran the following tests with the branch. The one fail was a hang in init that wrote ice error logs and seem to indicate it's the issue that's fixed by a different recent PR.

ERS.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.pm-cpu_gnu.allactive-nlmaps.gh6179                  fail   RUN nodes=   8 mins= 30.1 state=   TIMEOUT
ERS.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.pm-cpu_intel.allactive-nlmaps.gh6179                pass       nodes=   8 mins= 18.7 state= COMPLETED
ERS_D.ne30pg2_r05_IcoswISC30E3r5.F2010.pm-cpu_gnu.gh6179                                     pass       nodes=   8 mins= 35.0 state= COMPLETED
ERS_D.ne30pg2_r05_IcoswISC30E3r5.F2010.pm-cpu_intel.gh6179                                   pass       nodes=   8 mins= 71.6 state= COMPLETED
ERS_D_Ld3.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.pm-cpu_gnu.allactive-nlmaps.gh6179            pass       nodes=   8 mins= 18.4 state= COMPLETED
ERS_D_Ld3.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.pm-cpu_intel.allactive-nlmaps.gh6179          pass       nodes=   8 mins= 34.4 state= COMPLETED
ERS_D_Ld3.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.pm-cpu_nvidia.allactive-nlmaps.gh6179         pass       nodes=   8 mins= 51.3 state= COMPLETED
ERS_D_P512x1.ne30pg2_r05_IcoswISC30E3r5.F2010.pm-cpu_gnu.gh6179                              pass       nodes=   4 mins= 29.2 state= COMPLETED

@whannah1 whannah1 added the BFB PR leaves answers BFB label Dec 19, 2024
ndkeen
ndkeen approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@ndkeen ndkeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving only based on seeing that the changes seem to address the error I was seeing.

@rljacob rljacob assigned singhbalwinder and unassigned wlin7 Jan 9, 2025
@rljacob
Copy link
Member

rljacob commented Feb 7, 2025

@singhbalwinder can you please merge this?

@singhbalwinder
Copy link
Contributor

Sure, I will start merging it.

@singhbalwinder singhbalwinder changed the title add fice initialization to conv_water_init Adds fice initialization to conv_water_init Feb 7, 2025
@singhbalwinder
Copy link
Contributor

Merged to next

singhbalwinder added a commit that referenced this pull request Feb 7, 2025
@singhbalwinder
Merge branch 'whannah/atm/fix_conv_water_init' into next (PR #6858)
c0c2d49 
Adds fice initialization to conv_water_init

Add initialization of the "fice" pbuf variable within conv_water_init
to avoid debug mode failure when shr_infnan_isnan is called.

Fixes #6179.

[BFB]

* whannah/atm/fix_conv_water_init:
  add fice initialization to conv_water_init
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndkeen ndkeen ndkeen approved these changes

Assignees

@singhbalwinder singhbalwinder

Labels
BFB PR leaves answers BFB eam MMF
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Probably NaN in conv_water.F90 with ERS_D_Ld3.ne30pg2_r05_IcoswISC30E3r5.WCYCL1850.pm-cpu_gnu.allactive-nlmaps
5 participants
@whannah1 @ndkeen @rljacob @singhbalwinder @wlin7