EAMxx: Give option for for tracers to be advected only by dynamics #6789
Conversation
Increases the number of entries in the AtmosphereProcess set m_*_field_requests, but not the number of allocations. Allows us to output all instances of field requests of the same name.
tcclevenger
added
non-BFB
|
@tcclevenger Just to clarify: you said you're still working on ordering of tracers for PG2 and DYN grids, so is this PR not yet ready? |
Yes. Do we have a WIP equiv over here so I don't let the AT run while I work on getting a fix in? |
No we don't. But as soon as you push commits, you can click on the checks tab, and cancel all the jobs (one workflow at a time, unfortunately), if you know you're not done anyways... Edit: But we could modify our workflows jobs so that, for pull_request events, they only run if the PR is not in draft mode... |
|
What if you change it to draft PR ? |
I saw your reply just as I was editing my answer... Unfortunately, gh actions pull_request event still triggers, even if the PR is in draft mode (a debatable design choice, imho). The only way to skip them is to do something like jobs:
my-job:
if: ${{ github.event_name != "pull_request" || github.event.pull_request.draft == "false" }}
... |
|
@tcclevenger i removed the reviewer request. When you're ready, add them back, so gh pings me. If you'd rather us review right now, even before you fix the PG2-DYN issue, feel free to re-add me/us (I know balwinder is out for a month though). |
|
@tcclevenger what is the status? |
|
Still working on a fix for mismatch tracer indices between PG2 and GLL grid |
|
@tcclevenger any progress on fix? |
Yes, this is what I'm currently working on. Will update as I go. |
|
@tcclevenger please try to make this old PR a priority. |
|
@rljacob is it OK if we switch this to draft? |
|
Sure thats fine. |
|
@tcclevenger would you switch this to Draft if it's not ready? We'll try out that workflow. |
This is what I am currently working on, but the work is in a different branch (it contains a fundamental change to allocating groups of fields that doesn't make sense to throw onto this branch). Yes, I agree draft makes more sense for this PR. |
Processes can choose for a tracer to be advected only by dynamics (not by SHOC) by passing
turbulence_advected=falsetoadd_tracer(). Guards set up to ensure all tracers requests are consistent among processes.Moved over from E3SM-Project/scream#3085. Currently working on issue of tracer ordering between PG2 and GLL grids.