i#5383: Fix macOS arm64 test build/run #7171
Open
+40
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Disable selfmod tests due to build failures on M3 - Fix macOS build for mangle_pauth test (test still fails for some reason) - Mark dump_ucontext as NYI on macOS - Fixes NULL sigcontext_t in os_forge_exception - Adds -vm_size 500M to client tests to avoid reachablity assert
|
only a64 failure is raw-zlib #5635, doesn't seem to be my fault |
ndrewh
changed the title
edeiana
requested changes
Jan 3, 2025
| @@ -6040,7 +6047,9 @@ if (NOT ARM) # FIXME i#1551: fix bugs on ARM | |||
| endif () | |||
| endif (NOT ARM) | |||
|
|
|||
| if (X86 OR AARCH64) # FIXME i#1551: port asm to ARM | |||
| # FIXME i#1551: port asm to ARM | |||
| # FIXME i#xxx: selfmod tests fail to build on macOS + ARM64 | |||
There was a problem hiding this comment.
Change i#xxx with i#5383 (this falls within that issue).
| /* Since SIGCXT_FROM_UCXT just accesses the uc->uc_mcontext ptr field on | ||
| * macOS, sc will be NULL below if we do not initialize uc_mcontext first | ||
| */ | ||
| uc->IF_X64_ELSE(uc_mcontext64, uc_mcontext) = (void *)&frame->mc; |
There was a problem hiding this comment.
This seems weird.
frame is zeroed-out anyway, isn't this just changing sc to be a "different" NULL?
Also, shouldn't sc being NULL break more than MACOS?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes tests build and run properly on macOS (14.4) arm64 (M3). Many tests do not pass, but you can at least run them now.