i#1973 musl: fix build on musl libc #7168
Conversation
This introduces the MUSL macro.
bits/wordsize.h is a glibc-specific header, on musl __WORD_SIZE is defined as LONG_BIT. This is okay since Linux kernel assumes the size of long is equal to a machine word.
The pre-defined config.h is adjusted to match musl's features. We also to build and link lib/error.c to provide functions for error message handling.
As DynamoRIO enables -Werror by default, such warnings will prevent a warning-aware build. Since we also issue a warnings during start up, Let's remove it.
GCC on Alpine Linux enables "-Wtrampolines" by default, breaking the test. Since Alpine is the most widely-used musl-based distribution, it's worth to work around this: let's defaults to -Wno-trampoline on musl systems.
Some glibc-specific APIs are used in the test, we need to port them to musl.
DynamoRIO defines REG_* macros for compatibility with old clients, which conflict with signal.h on musl. Use of pragma push_macro/pop_macro to avoid messing musl's header up.
|
@derekbruening thanks for your review |
If this PR is ready for review, please add a reviewer from the "Reviewers" list on the top-right1. |
I have no write access to the repository, thus cannot require a reviewer :/ |
ziyao233
changed the title
ziyao233
changed the title
|
btw, may I have write access to the repository? I'm an intern of ISCAS and will continue working on riscv and musl port for DR, the access will help a lot (like adding an appropriate reviewer) |
Yes, I sent an invitation. |
| @@ -381,6 +381,9 @@ nolibc_print(const char *str) | |||
| 3, | |||
| # if defined(MACOS) || defined(ANDROID) | |||
| stderr->_file, | |||
| /* TODO i#1973: handle opaque FILE * on musl libc */ | |||
There was a problem hiding this comment.
See PR #7190: Android64 needs this too. Let's remove the ifdefs and use STDERR_FILENO everywhere, for tools.c anyway. Not sure whether #7190 should do that first and this one merge or vice versa: please coordinate: @jackgallagher-arm
There was a problem hiding this comment.
Oops, I didn't see the comment and got it merged.
There was a problem hiding this comment.
No problem, #7190 can put in code simplication here.
This pull request allows DynamoRIO and all the tests to be built on musl libc,
stdout/stderr and suppress warnings for musl's opaque FILE type
actually a function call, instead of a constant value
Tested on Alpine Linux, half of the tests are passed and it's possible to run
some applications (busybox, mutt and telegram-desktop) and some simple clients
(bbsize).
Issue: #1973