Fix all build warnings #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove unused variables in WGS84Converter.cs (re, slat, clat, tangc) - Add #nullable enable to MQTTControl.cs and Program.cs for nullable reference type annotations - Initialize nullable fields in MQTTControl.cs to fix nullable warnings - Suppress CS4014 warning for fire-and-forget async call in UWBManager.cs - Fix null reference warning in MQTTControl.Publish method Build now completes with 0 warnings.
Jen42
requested changes
Nov 24, 2025
Collaborator
Jen42
left a comment
Jen42
left a comment
There was a problem hiding this comment.
Please revert changes in [WGS84Converter.cs]
Jen42 requested to revert changes in WGS84Converter.cs. Restored original variable declarations (re, slat, clat, tangc) that were removed to fix warnings.
Jen42
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes all compiler warnings in the codebase.
Changes
re,slat,clat,tangc) that were declared but never used#nullable enabledirectivePublishmethod#nullable enabledirectiveResult
Build now completes with 0 warnings ✅
Testing