Add test for start menu icons

DustinBrett · Dec 2, 2024 · fdf4e4b · fdf4e4b
1 parent 371ccc7
commit fdf4e4b
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/e2e/components/system/StartMenu.spec.ts b/e2e/components/system/StartMenu.spec.ts
@@ -19,6 +19,7 @@ import {
   searchMenuIsHidden,
   searchMenuIsVisible,
   startMenuContextIsOpen,
+  startMenuEntryHasIcon,
   startMenuEntryIsVisible,
   startMenuIsHidden,
   startMenuIsVisible,
@@ -93,6 +94,8 @@ test.describe("has files", () => {
     for (const label of START_MENU_APPS) {
       // eslint-disable-next-line no-await-in-loop
       await startMenuEntryIsVisible(label, { page });
+      // eslint-disable-next-line no-await-in-loop
+      await startMenuEntryHasIcon(label, { page });
     }
   });
 

diff --git a/e2e/constants.ts b/e2e/constants.ts
@@ -203,6 +203,7 @@ export const START_MENU_APPS = [
   /^DevTools$/,
   /^IRC$/,
   /^Marked$/,
+  /^Messenger$/,
   /^Monaco Editor$/,
   /^Paint$/,
   /^PDF$/,
@@ -259,7 +260,7 @@ export const BASE_APP_TITLE = "daedalOS";
 export const BASE_APP_FAVICON = /^\/favicon.ico$/;
 export const BASE_APP_FAVICON_TEXT = "/favicon.ico";
 
-export const UNKNOWN_ICON_PATH = "/System/Icons/48x48/unknown.png";
+export const UNKNOWN_ICON_PATH = "/System/Icons/48x48/unknown.webp";
 
 const OG_REQUIRED_TAGS = ["title", "image", "url", "type"];
 

diff --git a/e2e/functions.ts b/e2e/functions.ts
@@ -606,6 +606,15 @@ const entryIsVisible = async (
     expect(page.locator(selector).getByLabel(label, EXACT)).toBeVisible()
   ).toPass();
 
+const entryHasIcon = async (
+  selector: string,
+  label: RegExp | string,
+  page: Page
+): Promise<void> =>
+  expect(
+    page.locator(selector).getByLabel(label, EXACT).locator("img")
+  ).not.toHaveAttribute("src", UNKNOWN_ICON_PATH);
+
 export const desktopEntryIsVisible = async (
   label: RegExp,
   { page }: TestProps
@@ -689,6 +698,11 @@ export const startMenuEntryIsVisible = async (
   { page }: TestProps
 ): Promise<void> => entryIsVisible(START_MENU_SELECTOR, label, page);
 
+export const startMenuEntryHasIcon = async (
+  label: RegExp | string,
+  { page }: TestProps
+): Promise<void> => entryHasIcon(START_MENU_SELECTOR, label, page);
+
 export const startMenuSidebarEntryIsVisible = async (
   label: RegExp,
   { page }: TestProps