Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for attachments before jumping into switch/case statement #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

InsidiousClu
Copy link

This change includes check of the part of the form for attachment detection, before we jump into the switch/case statement.
This gives us ability to extract attachments with mime-type of text/html as well, rather appending that to the html body

where we initially check whether part is the attachments.
Rather doing that in the last step, otherwise attachments with mimetype
of text/html would not be extracted out of the eml file
@agentabstract
Copy link

I was having the problem with text attachments. Attached text files were being stored in the textbody field instead of being in the attachments where they belong. I copied @InsidiousClu changes and now my parsemail library is working perfectly. IMHO this code should be merged into the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants