Check for attachments before jumping into switch/case statement #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
where we initially check whether part is the attachments. Rather doing that in the last step, otherwise attachments with mimetype of text/html would not be extracted out of the eml file
|
I was having the problem with text attachments. Attached text files were being stored in the textbody field instead of being in the attachments where they belong. I copied @InsidiousClu changes and now my parsemail library is working perfectly. IMHO this code should be merged into the master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change includes check of the part of the form for attachment detection, before we jump into the switch/case statement.
This gives us ability to extract attachments with mime-type of text/html as well, rather appending that to the html body