Skip to content

Conversation

@someson
Copy link

@someson someson commented Oct 22, 2024

according to #52 (comment) my job is done, pls check

some notes:

  • i don't understand why is there the /types folder, it has nothing to do with purpose of this/parent project. There's carbonphp/carbon-doctrine-types package as an externalization of nestbot/carbon package for this usecase.
  • for production (without nesbot/carbon) all the classes in /types folder are not usable (lack of Carbon namespase)
  • so I moved the /types to /tests, but what are we testing there, if those classes have no sense in the package? I would remove it completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant