Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for Laravel 8 #34

Closed
wants to merge 3 commits into from
Closed

Initial support for Laravel 8 #34

wants to merge 3 commits into from

Conversation

igibek
Copy link

@igibek igibek commented Sep 10, 2020

Issue #33
I made changes according to official laravel documentation: https://laravel.com/docs/8.x/upgrade#seeder-factory-namespaces

@igibek
Copy link
Author

igibek commented Sep 10, 2020

This pull request introduces a breaking change for applications that uses Laravel 7. So, we need to create a new version of the package (3.0) and push it.

@MrCrayon
Copy link
Contributor

@igibek I think we can detect Laravel version and use the appropriate folder, at the same time have a placeholder for {{namespace}} and replace it with the correct string.
This way we keep compatibility.
You can have a look at getSeedsFolderName in my PR for Voyager thedevdojo/voyager#5093

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants