Resume scroll position #429
Open
+32
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k3125/conference-app-2017 into feature/opne-app-with-session-date
konifar
reviewed
Mar 10, 2017
| @@ -68,4 +68,8 @@ public Context getContext() { | |||
| return context; | |||
| } | |||
|
|
|||
| @Override | |||
| public Iterator<T> iterator() { | |||
There was a problem hiding this comment.
[Android Lint] reported by reviewdog 🐶
error: cannot find symbol
konifar
reviewed
Mar 10, 2017
| @@ -116,6 +121,9 @@ public void onResume() { | |||
| @Override | |||
| public void onStop() { | |||
| super.onStop(); | |||
| int position = binding.recyclerView.getFirstVisiblePosition(); | |||
| Log.d(TAG, "onStop: " + position); | |||
There was a problem hiding this comment.
[Android Lint] reported by reviewdog 🐶
Error: Using 'Log' instead of 'Timber' [LogNotTimber]
konifar
reviewed
Mar 10, 2017
| @@ -116,6 +121,8 @@ public void onResume() { | |||
| @Override | |||
| public void onStop() { | |||
| super.onStop(); | |||
| int position = binding.recyclerView.getFirstVisiblePosition(); | |||
| sharedPreferences.edit().putInt("last_position", position).apply(); | |||
There was a problem hiding this comment.
Actually this app uses kvs-schema.
So you can use auto generated method to access shared preferences.
Can you follow the steps below?
1. Add key to DefaultPrefsSchema
@Table(name = "io.github.droidkaigi.confsched_preferences")
public interface DefaultPrefsSchema {
...
@Key(name = "last_sessions_view_position")
int lastSessionsViewPosition;
}2. Use generated method.
DefaultPrefs prefs = DefaultPrefs.get(context);
int lastPosition = prefs.getLastSessionsViewPosition();
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Links
Screenshot