Add user_id to CreateOrUpdateSubscriber #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
was this PR rejected for some reason, or was the repo simply abandoned? |
|
It's abandoned at this point. We haven't put the resources into keeping it up to date and working. We've been discussing applying people to this internally. I'll take a look at this PR and get you a better answer. |
|
Hi @will-in-wi I hope you find the time internally to update this project in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for specifying the user_id field when creating or updating a subscriber.
I also updated the unit tests to support and test this field.
Note that this change was only made to the VS 2015 solution. I don't have access to VS 2013 to make the change in the VS 2013 solution, and my recommendation is that you remove that solution from the .NET SDK as it is now two versions old with the recent introduction of VS 2017.