#324 Refactor 댓글 entity 수정 및 로직 수정 #353
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
djlim2425
commented
Jan 13, 2025
djlim2425
commented
- 기본적으로 소프트 딜리트하도록 구현
- 댓글 수정기능 추가
- 변경된 entity에 따른 로직들 수정 - recomment 주석처리 (comment와 연관된)
Closed
3 tasks
jeongyun1206
requested changes
Jan 13, 2025
There was a problem hiding this comment.
orphanRemoval 제거가 필요합니다.
There was a problem hiding this comment.
partyService.findPartyById(partyId); 의 경우 단순 조회로 repository로 구현하는게 좋아보입니다.
There was a problem hiding this comment.
dto 접미사 제거해서 파일 형식 맞춰주는게 좋아보입니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.