fix: Remove player action not being sent

This issue was introduced in f0c8db9
DrexHD · Sep 17, 2022 · f20856b · f20856b
1 parent df3896a
commit f20856b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,7 +12,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ### Changed
 - Improve packet filtering
-- Improve API performance
+- Improve performance
 
 ### Fixed
 - Environment sound are no longer removed

diff --git a/src/main/java/me/drex/vanish/mixin/ServerGamePacketListenerImplMixin.java b/src/main/java/me/drex/vanish/mixin/ServerGamePacketListenerImplMixin.java
@@ -53,13 +53,15 @@ public void vanish_modifyPackets(Packet<?> packet, GenericFutureListener<? exten
             }
         } else if (packet instanceof ClientboundPlayerInfoPacket playerInfoPacket) {
             ObjectArrayList<ServerPlayer> modifiedEntries = new ObjectArrayList<>();
+            int visible = 0;
             for (ClientboundPlayerInfoPacket.PlayerUpdate playerUpdate : playerInfoPacket.getEntries()) {
                 if (VanishAPI.canSeePlayer(server, playerUpdate.getProfile().getId(), this.player)) {
+                    visible++;
                     ServerPlayer player = server.getPlayerList().getPlayer(playerUpdate.getProfile().getId());
                     if (player != null) modifiedEntries.add(player);
                 }
             }
-            if (modifiedEntries.size() != playerInfoPacket.getEntries().size()) {
+            if (visible != playerInfoPacket.getEntries().size()) {
                 if (!modifiedEntries.isEmpty()) {
                     this.send(new ClientboundPlayerInfoPacket(playerInfoPacket.getAction(), modifiedEntries));
                 }