Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added herocard to keyboard support #2

Closed
wants to merge 2 commits into from
Closed

Added herocard to keyboard support #2

wants to merge 2 commits into from

Conversation

austinhuang0131
Copy link

@austinhuang0131 austinhuang0131 commented Nov 6, 2017

As a response to #1. It should look like how Kik supports hero cards.

@austinhuang0131
Copy link
Author

Also fixed your package.json cuz npm doesn't auto-install devDependencies

@alexsorokoletov
Copy link
Contributor

@austinhuang0131 looks good to me, do you have any example handy how a hero card looks in Skype, FB and Viber correspondingly?

@austinhuang0131
Copy link
Author

austinhuang0131 commented Nov 6, 2017 via email

@alexsorokoletov
Copy link
Contributor

@austinhuang0131 Austin when you have a chance, I'd like to see how hero card from standard channels will render now in Viber, that's it.

Attach a screenshot from your test scenario, I will check it and we will merge and update the npm package.

I appreciate both the improvement and fixes. 👍

@alexsorokoletov
Copy link
Contributor

@austinhuang0131 waiting here for a screenshot from your side to make sure everything looks just fine.

https://www.atlassian.com/blog/git/written-unwritten-guide-pull-requests

@austinhuang0131
Copy link
Author

which I'll have to solve #3 first

@alexsorokoletov
Copy link
Contributor

@austinhuang0131 do you need any help with #3? I thought you're no longer interested in it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants