CI: Overhaul build matrix for Ubuntu runners and work around issue with Clang #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The complexity of the build matrix for the Ubuntu runners grew to a level which made it very difficult to understand which set of runners will be started with which configuration. Overhaul the build matrix settings by moving most of its complexity to the build steps. That should make it easier to potentially adjust the settings for one of the runners in the matrix in the future.
It looks like the stack is smashed at some point in GraphBLAS when using Clang as the compiler on Ubuntu with optimization level `-O3`. It's currently unclear to me why that happens. But changing the build type to "Debug" (i.e., optimization level `-O0`) works around that issue.
Building CHOLMOD_CUDA requires OpenMP. Instead of failing later on during compilation, emit an error during configuration that point to the underlying issue.
|
It looks like all Ubuntu runners are passing their tests again. (I didn't have a look at the tests for MSVC with Clang yet.) @DrTimothyAldenDavis: When you come around to it, could you please merge this PR? I'd like to rebase #894 on top of the changes from this PR. |
|
Shall do -- thanks! I'm travelling just now though ... give me a few days to get a change to take a look. |
|
on 2nd thought ... it looks pretty clear. I'll merge it now. |
DrTimothyAldenDavis
merged commit 7f5e703
into
DrTimothyAldenDavis:dev2
25 of 27 checks passed
|
Thank you! And safe journey! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The complexity of the build matrix for the Ubuntu runners grew to a level which made it very difficult to understand which set of runners will be started with which configuration.
Overhaul the build matrix settings by moving most of its complexity to the build steps.
That should make it easier to potentially adjust the settings for one of the runners in the matrix in the future.
It looks like the stack is smashed at some point in GraphBLAS when using Clang as the compiler on Ubuntu with optimization level
-O3.It's currently unclear to me why that happens. But changing the build type to "Debug" (i.e., optimization level
-O0) works around that issue.While looking at the issue with Clang on Ubuntu, I came across a couple other (less related) changes which I think are sensible: