CMake: Adjust condition for changed name for static libraries. #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MSVC-like compilers use the same default suffix for static libraries and import libraries. Instead of checking whether a compiler is MSVC or simulates it, directly check whether these default suffices clash. That potentially fixes issue DrTimothyAldenDavis#895. (And even in case it does not, the updated condition is much more to the point.
|
Turns out that #895 was probably caused by an issue with NMake (i.e., most likely upstream). Closing this PR because it didn't change anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MSVC-like compilers use the same default suffix for static libraries and import libraries.
Instead of checking whether a compiler is MSVC or simulates it, directly check whether these default suffices clash.
That potentially fixes issue #895. (And even in case it does not, the updated condition is much more to the point.)