umfpack, suitesparse_config, CI #828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UMFPACK is built without OpenMP. (It doesn't use it directly.) Hence, `_OPENMP` is not defined when the UMFPACK libraries are built. Get the information about the used timer function directly from SuiteSparse_config.h instead. Fixes #822.
Record in "SuiteSparse_config.h" if working timer functions are available in libsuitesparse_config. Always indirect to `SuiteSparse_time` when dependent libraries use `SUITESPARSE_TIME`. Add new preprocessor macro `SUITESPARSE_CONFIG_TIMER` which records the function that is used by libsuitesparse_config for its timer functions. Use that new preprocessor macro in the reports of UMFPACK.
Avoid indirection through the library if the compilation unit including `SuiteSparse_config.h` happens to use OpenMP.
GitHub seems to be updating their runner images to include MSVC 19.40 currently. NVIDIA CUDA seems to think this newer version of MSVC is no longer Microsoft Visual Studio 2022 (but it is). Work around that issue by adding `-allow-unsupported-compiler` to the CUDA flags. Additionally, it looks like the PATH variable on these runner images is arranged such that a different (older) `clang-cl` is being picked up by CMake instead of the newer one from MSVC 19.40. Work around that by moving that version out of the PATH so CMake picks the compiler that is installed with Microsoft Visual Studio.
Including headers (from the standard library) in extern "C" blocks can be problematic. Use extern "C" block only around function declarations.
SuiteSparse_config: Avoid including headers in extern "C" block.
CI (MSVC): Update build rules for MSVC 19.40
UMFPACK: Display timer function used by SuiteSparse_config in report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.