Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install SuiteSparse headers in subdirectory by default #568

Merged
merged 1 commit into from
Dec 3, 2023

Conversation

mmuetzel
Copy link
Contributor

@mmuetzel mmuetzel commented Dec 3, 2023

This change would install (most of) the headers of SuiteSparse libraries to a subfolder suitesparse of the include folder.
That would prevent accidental inclusion of older SuiteSparse headers when the system include directory is added to the preprocessor search path. See #558.

@DrTimothyAldenDavis
Copy link
Owner

I will give it a try. I can see that this could help avoid conflicts with /usr/local/include (my omp.h is there). So this is probably a good thing to add. If a package manager wants to move them elsewhere, they can do that themselves.

But if omp.h is in /opt/homebrew/include, alongside a stale amd.h from "brew install suite-sparse", then that will still cause a problem.

@DrTimothyAldenDavis DrTimothyAldenDavis merged commit 2f9d84e into DrTimothyAldenDavis:dev2 Dec 3, 2023
24 checks passed
@mmuetzel
Copy link
Contributor Author

mmuetzel commented Dec 3, 2023

I will give it a try. I can see that this could help avoid conflicts with /usr/local/include (my omp.h is there). So this is probably a good thing to add. If a package manager wants to move them elsewhere, they can do that themselves.

But if omp.h is in /opt/homebrew/include, alongside a stale amd.h from "brew install suite-sparse", then that will still cause a problem.

Yes, this won't fix it when the installed SuiteSparse headers are already mixed with the headers from other libraries. But it might make life easier at some point in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants