Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LAGraph: Also look for GraphBLAS import target in common build tree #548

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

mmuetzel
Copy link
Contributor

That is needed when using the root CMakeLists.txt.

That is needed when using the root CMakeLists.txt.
@DrTimothyAldenDavis
Copy link
Owner

Doesn't this have to happen for all packages? There could be a system amd.h or cholmod.h for example, and my other packages that depend on those mist link against the libraries and include files in the new build tree. Those must take precedence over any other system amd.h, cholmod.h etc

@DrTimothyAldenDavis
Copy link
Owner

Or is that already in place but LAGraph is different because might need to look for other GraphBLAS implementations?

@mmuetzel
Copy link
Contributor Author

mmuetzel commented Nov 29, 2023

Doesn't this have to happen for all packages? There could be a system amd.h or cholmod.h for example, and my other packages that depend on those mist link against the libraries and include files in the new build tree. Those must take precedence over any other system amd.h, cholmod.h etc

If I understand correctly, that shouldn't be a problem for the other libraries. They already have rules that prefer the libraries in the common source or build tree.

It's only the special logic in LAGraph that has more rules to find different versions of GraphBLAS that needs this change afaict.

@DrTimothyAldenDavis
Copy link
Owner

Got it. Yes, that makes sense. Glad we caught this issue before SuiteSparse 7.4.0.beta1 was formally released. Thanks for the fix!

@DrTimothyAldenDavis DrTimothyAldenDavis merged commit 5dd2175 into DrTimothyAldenDavis:dev2 Nov 29, 2023
23 checks passed
@mmuetzel
Copy link
Contributor Author

Glad we caught this issue before SuiteSparse 7.4.0.beta1 was formally released.

Sorry this slipped through.
It probably even picked up the GraphBLAS installed on my system during my testing without me noticing (because it is new enough). To look at the positive sight: That likely means that that CMake module is capable of importing different versions of GraphBLAS. 😉
But I'm also glad that this showed up during @Fabian188's tests. Took me a while to understand what was going on though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants