SPEX: Allocate enough memory for NULL terminator.

Fixes #847. Thank you to Sébastien Villemot for pointing out the fix.
DrTimothyAldenDavis · Jul 7, 2024 · dfc51ea · dfc51ea
1 parent 448bc50
commit dfc51ea
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/SPEX/Python/SPEXpy/Source/spex_python_connect.c b/SPEX/Python/SPEXpy/Source/spex_python_connect.c
@@ -109,7 +109,7 @@ SPEX_info spex_python
 
     //--------------------------------------------------------------------------
     // solve Ax=b
-    //-------------------------------------------------------------------------
+    //--------------------------------------------------------------------------
     switch(algorithm)
     {
         case 1:
@@ -130,7 +130,7 @@ SPEX_info spex_python
 
     //--------------------------------------------------------------------------
     // Return output as desired type
-    //-----------------------------------------------------------------------
+    //--------------------------------------------------------------------------
     if(charOut)
     {
         //solution as string
@@ -143,12 +143,12 @@ SPEX_info spex_python
                 printf("error converting x to string");
             }
             //check string size
-            int sizeStr;
-            sizeStr=strlen(s);
+            size_t sizeStr;
+            sizeStr = strlen(s);
             //allocate sol_char[i]
-            sol_void[i] = (void*) malloc (sizeStr*sizeof(char));
+            sol_void[i] = malloc (sizeStr + 1);  // +1 for NULL terminator
             //copy s into sol_char[i]
-            strcpy(sol_void[i],s);
+            strcpy(sol_void[i], s);
         }
     }
     else