hanldes fixes for dd api processor

drdroid_debug_toolkit/core/integrations/source_api_processors/datadog_api_processor.py

@@ -435,14 +435,76 @@ def test_connection(self):
         try:
             configuration = self.get_connection()
             with ApiClient(configuration) as api_client:
-                api_instance = AuthenticationApi(api_client)
-                response: AuthenticationValidationResponse = api_instance.validate()
-                if not response.get('valid', False):
-                    raise Exception("Datadog API connection is not valid. Check API Key")
+                # Validate API Key (this endpoint only requires API key)
+                try:
+                    api_instance = AuthenticationApi(api_client)
+                    response: AuthenticationValidationResponse = api_instance.validate()
+                    if not response.get('valid', False):
+                        raise Exception("Datadog API Key is not valid. Check API Key")
+                except ApiException as e:
+                    logger.error("Exception when validating API Key: %s\n" % e)
+                    raise Exception("Datadog API Key is not valid. Check API Key")
+
+                # Validate Application Key by making a call that requires both keys
+                # Since API key is already validated, check error body for specific Application Key errors
+                try:
+                    monitors_api_instance = MonitorsApi(api_client)
+                    monitors_api_instance.list_monitors(page_size=1)
+                except ApiException as e:
+                    logger.error("Exception when validating Application Key: %s\n" % e)
+                    # Check the error body for specific messages about Application Key
+                    error_body = e.body if hasattr(e, 'body') else None
+                    error_str = str(e).lower()
+
+                    # Check if error explicitly mentions Application Key
+                    app_key_indicators = [
+                        "application key",
+                        "app key",
+                        "appkeyauth",
+                        "dd-application-key",
+                        "invalid application key",
+                        "missing application key"
+                    ]
+
+                    # Check if error explicitly mentions API Key
+                    api_key_indicators = [
+                        "api key",
+                        "apikeyauth",
+                        "dd-api-key",
+                        "invalid api key",
+                        "missing api key"
+                    ]
+
+                    # Check error body (could be dict or string)
+                    body_str = ""
+                    if isinstance(error_body, dict):
+                        body_str = str(error_body).lower()
+                    elif isinstance(error_body, str):
+                        body_str = error_body.lower()
+
+                    # Check if error message specifically mentions Application Key
+                    if any(indicator in error_str or indicator in body_str for indicator in app_key_indicators):
+                        raise Exception("Datadog Application Key is not valid. Check Application Key")
+                    # Check if error message specifically mentions API Key
+                    elif any(indicator in error_str or indicator in body_str for indicator in api_key_indicators):
+                        raise Exception("Datadog API Key is not valid. Check API Key")
+                    # If status is 403 and we got past API key validation, it's likely Application Key
+                    elif hasattr(e, 'status') and e.status == 403:
+                        raise Exception("Datadog Application Key is not valid. Check Application Key")
+                    # Otherwise, provide a generic error message
+                    else:
+                        error_details = f"Status: {e.status if hasattr(e, 'status') else 'Unknown'}"
+                        if error_body:
+                            error_details += f", Error: {error_body}"
+                        raise Exception(f"Datadog connection failed. {error_details}. Please check both API Key and Application Key")
+
                 return True
-        except ApiException as e:
-            logger.error("Exception when calling AuthenticationApi->validate: %s\n" % e)
-            raise e
+        except Exception as e:
+            # Re-raise if it's already our custom exception
+            if "Datadog" in str(e) and ("API Key" in str(e) or "Application Key" in str(e) or "connection failed" in str(e)):
+                raise e
+            logger.error("Exception when testing Datadog connection: %s\n" % e)
+            raise Exception(f"Datadog connection failed: {str(e)}. Please check both API Key and Application Key")
 
     def fetch_metric_timeseries(self, tr: TimeRange, specific_metric, interval=300000):
         metric_queries = specific_metric.get('queries', None)