Skip to content

Fix SA1514: Do not report when documenting types declared in the global namespace #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 24, 2025
Merged

Fix SA1514: Do not report when documenting types declared in the global namespace #3863

merged 4 commits into from
Nov 24, 2025

Conversation

@MattFromRVA
Copy link
Contributor

@MattFromRVA MattFromRVA commented Jun 26, 2024

Fixes #3849

@codecov
Copy link

codecov bot commented Jun 26, 2024 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.46%. Comparing base (51c772e) to head (86f274a).
⚠️ Report is 57 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##           master    #3863     +/-   ##
=========================================
  Coverage   97.45%   97.46%             
=========================================
  Files         926      934      +8     
  Lines      110202   111276   +1074     
  Branches     3312     3339     +27     
=========================================
+ Hits       107398   108451   +1053     
- Misses       1837     1850     +13     
- Partials      967      975      +8
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MattFromRVA MattFromRVA marked this pull request as draft July 2, 2024 02:05
@MattFromRVA MattFromRVA marked this pull request as ready for review July 2, 2024 17:26
@MattFromRVA MattFromRVA mentioned this pull request Jul 30, 2025
Merged
sharwell
sharwell reviewed Nov 24, 2025
View reviewed changes
@sharwell sharwell enabled auto-merge November 24, 2025 02:09
@sharwell sharwell merged commit ada7d92 into DotNetAnalyzers:master Nov 24, 2025
21 checks passed
@sharwell sharwell added this to the 1.2-beta.next milestone Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sharwell sharwell sharwell approved these changes

+1 more reviewer

@bjornhellander bjornhellander bjornhellander approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.2-beta.next

Development

Successfully merging this pull request may close these issues.

SA1514 is falsely reported when documenting types declared in the global namespace

3 participants

@MattFromRVA @sharwell @bjornhellander