Feat: 로그인 시 토큰 저장 및 middleware 설정 #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
D5ng
reviewed
Jun 1, 2024
middleware.ts
Outdated
| // /start-family 페이지로 접근하는데 token이 없을 경우 : 리다이렉션 | ||
| // /start-family 페이지로 접근하는데 token이 없지만 쿠키가 있을 경우 : 페이지 접근 | ||
| // 추후 배포됐을 때 수정. | ||
| if (path === '/start-family' && hasQuery) { |
There was a problem hiding this comment.
이부분은 고민을 더 해보는게 좋아보이네요. 이렇게 if문이 많이 생기면 가독성이 확 떨어집니다.
객체 맵핑을 사용해도 좋고, 아니면 더 줄일 수 있는 방법을 고민해봐야할듯 해요
forestream
approved these changes
Jun 1, 2024
middleware.ts
Outdated
| } | ||
|
|
||
| export const config = { | ||
| matcher: ['/login', '/start-family'], |
There was a problem hiding this comment.
matcher: [ ...PROTECTED_PAGES, ...PUBLIC_PAGES ]
여길 이렇게 바꿀 수 있을까 생각해봤습니다
There was a problem hiding this comment.
오... 어떻게 넣을까 고민했었는데 스프레드가 있었군요
감사합니다 변경하겠습니다!
mun-jihye
approved these changes
Jun 2, 2024
…feature/start-family
DHyeon98
added a commit
to DHyeon98/Donggrina
that referenced
this pull request
Jun 3, 2024
Feat: 로그인 시 토큰 저장 및 middleware 설정
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣연관된 이슈
📝작업 내용
start-family
middleware
스크린샷 (선택)
💬리뷰 요구사항(선택)