Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20240225 mme multi leader rework #293

Merged
merged 14 commits into from
Mar 20, 2024
Merged

20240225 mme multi leader rework #293

merged 14 commits into from
Mar 20, 2024

Conversation

mme1950
Copy link
Contributor

@mme1950 mme1950 commented Feb 29, 2024

Fixes issues #292 and #273.

mme1950 and others added 8 commits February 29, 2024 17:36
@mme1950
- MultiLeaderStyle: Comments + TODOs
e8e351d 
-  MultiLeaderPropertyOverrideFlags: Misspelled enum identifier
-  MultiLeaderAnnotContext:
       OverallScale --> ScaleFactor (consistency!)
       property TextAttachmentPoint (group code: 171)
-  MultiLeaderAnnotContext.LeaderRoot: AttachmentDirection (internal set --> set)
-  MultiLeaderAnnotContext.LeaderLine: no setters for IList properties
@mme1950
Merge branch 'DomCR:master' into 20240225_mme_MultiLeader_rework
003636b
@mme1950
- AttachmentType --> BlockContentConnection
5d2cc56 
-  Use enum BlockContentConnectionType, delete enum AttachmentType
@mme1950
Merge branch '20240225_mme_MultiLeader_rework' of https://github.com/…
f90b346 
…nanoLogika/ACadSharp into 20240225_mme_MultiLeader_rework
@mme1950
- updated for changed properties
2ab58a5
@mme1950
- MultiLeaderStyle: comment
9e26259
@mme1950
- comment corrected
98e8450
@mme1950
- Normal --> TextNormal, BlockContentNormal
51cc930 
- Location --> TextLocation, BlockContentLocation
- Rotation --> TextRotationl, BlockContentRotation
@mme1950 mme1950 marked this pull request as ready for review March 6, 2024 06:52
@mme1950
Copy link
Contributor Author

mme1950 commented Mar 6, 2024

Hi @DomCR,

I created detailed comments in MultiLeaderand MultiLeaderAnnotContext.
But I would recommend to merge the current state and leave the comments for another PR.

@mme1950 mme1950 mentioned this pull request Mar 18, 2024
Closed
@mme1950
Copy link
Contributor Author

mme1950 commented Mar 18, 2024

Hi @DomCR,
thank you for resolving 16 spurious bits in readMultiLeader.
You changed the restriction of MultiLeader to AutoCAD version 2010+.
I am not sure it will work, since we found some inconsitancies in the documentation and we could not test it.

@DomCR
Copy link
Owner

DomCR commented Mar 18, 2024

Hi @DomCR, thank you for resolving 16 spurious bits in readMultiLeader. You changed the restriction of MultiLeader to AutoCAD version 2010+. I am not sure it will work, since we found some inconsitancies in the documentation and we could not test it.

I've added tests to check the different versions, and I haven't modified the current flow besides the fix for the 16 bits, if you spot an issue with the new implementation report it as an issue and in the mean time I'll roll back the changes.

@DomCR
Copy link
Owner

DomCR commented Mar 18, 2024

If you make the changes I think this is ready to go!

Great job!!!

@mme1950
Copy link
Contributor Author

mme1950 commented Mar 18, 2024

Hi @DomCR:

If you make the changes I think this is ready to go!

  • Please lets discuss whether we really should split the MultiLeaderStyle.BlockContentScale property. Is there is an alternate way to support the Dxf reading?

Planned for next PRs:

  • Writers
  • We created a lot of comments, that I have to verify. TODOs regarding understandung must be solved.
  • Lets discuss how to handle dependecies between the MultiLeader properties.

@mme1950
Copy link
Contributor Author

mme1950 commented Mar 20, 2024

Hi @DomCR,
could you please merge this branch. Then we can proceed to the writers.

@DomCR DomCR merged commit e398566 into DomCR:master Mar 20, 2024
2 checks passed
@mme1950 mme1950 deleted the 20240225_mme_MultiLeader_rework branch March 20, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DomCR DomCR DomCR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mme1950 @DomCR