Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX invoice creation : use dol_include_once instead of require_once to allow external modules. #33131

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

thomas-Ngr
Copy link
Contributor

@thomas-Ngr thomas-Ngr commented Feb 19, 2025

Fix : Impossible to create a supplier invoice from an object introduced by an external module

Loading the class of the origin element should be done through dol_include_once and not require_once, to allow use from external modules.

This is right on most cards:

  • compta/facture/card.php
  • comm/propal/card.php
  • commande/card.php
  • fourn/commande/card.php
  • fourn/propal/card.php

.. but not on fourn/facture/card.php

Copy link
Contributor

@rycks rycks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as it's already done on other cards it's ok for me

@eldy eldy merged commit 00ccb45 into Dolibarr:18.0 Feb 21, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants