-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: allow bookcal display on calendar list #32513
Conversation
…r entities) debug/security : add check on entites for bookcals
phpstan error on code i didn't change, I can correct it if someone can pin to a standard correction (cast?) |
Module builder add more and more code with no sense !! getEntity($object->element) doesn't make sense, object is "availabilities" and "bookcal_availabilities" table has no entity field !! |
@eldy ce n'est que mon opinion, mais un module fait avec Module Builder et qu'on veut intégrer a Dolibarr devrait être nettoyé, voir réécrit correctement ! |
i just don't have time to clean/recreate it from scratch, so try fixing what i can for my own needs ! (working in production env) |
it doesn't but bookcal_calendar have it, see my old PR (and Eldy comments) on it : #29212 |
fixed : $object->element to 'calendar', in getEntity |
disable checks on "filtert" (default does not allow bookcal from other entities)
fix : add check on entites for bookcals
FIX bookcal : FIX : check on entities + not displaying calendar if multicompany ON
In multicompany context, we have to check on entities so only display shared agenda/bookcal AND have to disable checks on "filtert" (default only allow bookcal from same user, but is not altered by bookcal)