Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: allow bookcal display on calendar list #32513

Merged
merged 6 commits into from
Jan 3, 2025

Conversation

G-ladal
Copy link
Contributor

@G-ladal G-ladal commented Jan 3, 2025

disable checks on "filtert" (default does not allow bookcal from other entities)
fix : add check on entites for bookcals

FIX bookcal : FIX : check on entities + not displaying calendar if multicompany ON

In multicompany context, we have to check on entities so only display shared agenda/bookcal AND have to disable checks on "filtert" (default only allow bookcal from same user, but is not altered by bookcal)

@G-ladal
Copy link
Contributor Author

G-ladal commented Jan 3, 2025

phpstan error on code i didn't change, I can correct it if someone can pin to a standard correction (cast?)

@hregis
Copy link
Contributor

hregis commented Jan 3, 2025

Module builder add more and more code with no sense !! getEntity($object->element) doesn't make sense, object is "availabilities" and "bookcal_availabilities" table has no entity field !!

@hregis
Copy link
Contributor

hregis commented Jan 3, 2025

@eldy ce n'est que mon opinion, mais un module fait avec Module Builder et qu'on veut intégrer a Dolibarr devrait être nettoyé, voir réécrit correctement !

@G-ladal
Copy link
Contributor Author

G-ladal commented Jan 3, 2025

@eldy ce n'est que mon opinion, mais un module fait avec Module Builder et qu'on veut intégrer a Dolibarr devrait être nettoyé, voir réécrit correctement !

i just don't have time to clean/recreate it from scratch, so try fixing what i can for my own needs ! (working in production env)

@G-ladal
Copy link
Contributor Author

G-ladal commented Jan 3, 2025

Module builder add more and more code with no sense !! getEntity($object->element) doesn't make sense, object is "availabilities" and "bookcal_availabilities" table has no entity field !!

it doesn't but bookcal_calendar have it, see my old PR (and Eldy comments) on it : #29212

@G-ladal
Copy link
Contributor Author

G-ladal commented Jan 3, 2025

fixed : $object->element to 'calendar', in getEntity

@eldy eldy merged commit 11eee91 into Dolibarr:develop Jan 3, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants