NEW #30044 #30071
Open
NEW #30044 #30071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Jun 19, 2024
| @@ -2500,13 +2500,7 @@ function pdf_getLinkedObjects(&$object, $outputlangs) | |||
| } elseif ($objecttype == 'commande' || $objecttype == 'supplier_order') { | |||
| $outputlangs->load('orders'); | |||
|
|
|||
| if (count($objects) > 1 && count($objects) <= (getDolGlobalInt("MAXREFONDOC") ? getDolGlobalInt("MAXREFONDOC") : 10)) { | |||
There was a problem hiding this comment.
Removing generation from pdf_getLinkedObjects() to replace it by public_note seems a good idea.
However, the option getDolGlobalInt("MAXREFONDOC") must still be used to limit size of the public_note.
eldy
added
the
Discussion
eldy
reviewed
Jun 30, 2024
| $objecttmp->note_public = dol_concatdesc($objecttmp->note_public, $langs->transnoentities($cmd->ref).(empty($cmd->ref_client) ? '' : ' ('.$cmd->ref_client.')')); | ||
| $objecttmp->update($user); | ||
| } | ||
|
|
There was a problem hiding this comment.
To avoid such errors, you should think to activate the "pre-commit" hooks in your development environment:
See https://wiki.dolibarr.org/index.php?title=Environment_and_development_tools#Install_Pre-commit_githook
eldy
added
PR to fix or conflict to solve
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX #30044