Updated version of Kevin's fixes for sign-in #2394
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # public/api/getQuickCheckSignedIn.php # src/Tools/_framework/Paths/SiteHeader.jsx
|
Tabling this until after the semester given how much code was changed here, replacing with a simpler PR that just makes sign out work after adding google analytics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issues around incorrectly reporting that sign-out failed and that cookies need to be cleaned out manually. There is also some nice work to improve the design of the sign-in and sign-out pages.
I just merged with the main branch and removed some unnecessary PHP changes that added an extra processing loop to SQL results.
Replaces #2373