Skip to content

Chakra Button and ButtonGroup #2188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: legacy
Choose a base branch
from
Open

Chakra Button and ButtonGroup #2188

wants to merge 6 commits into from

Conversation

@keaganeng
Copy link
Contributor

@keaganeng keaganeng commented May 30, 2023 •
edited
Loading

Converting /src/_reactComponents/PanelHeaderComponents/Button.jsx into a Chakra component.

All Chakra-converted components now live in this folder: /src/_reactComponents/ChakraComponents/

@keaganeng keaganeng changed the title Chakra button from uiDocs Chakra button for uiDocs May 31, 2023
@keaganeng keaganeng self-assigned this May 31, 2023
@keaganeng keaganeng changed the title Chakra button for uiDocs Chakra Button and ButtonGroup Jun 2, 2023
@keaganeng
Copy link
Contributor Author

keaganeng commented Jun 2, 2023

To view in UI Docs, visit http://localhost:8000/src/Tools/uiDocs/.
To view and test in Temp Tool, visit http://localhost:8000/src/Tools/temp/.

Future work:

  • Update the UI Docs New Component Guidelines
  • Remove ActionButton and ActionButtonGroup (instead, pass the isAttached prop to ButtonGroup)
  • Update all other components to use Chakra UI

@keaganeng keaganeng marked this pull request as ready for review June 2, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kevincharles kevincharles Awaiting requested review from kevincharles

@jaltekruse jaltekruse Awaiting requested review from jaltekruse

@dqnykamp dqnykamp Awaiting requested review from dqnykamp

At least 1 approving review is required to merge this pull request.

Assignees

@keaganeng keaganeng

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@keaganeng