Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] v3 #295

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

[WIP] v3 #295

wants to merge 39 commits into from

Conversation

DoctorMcKay
Copy link
Owner

@DoctorMcKay DoctorMcKay commented Feb 5, 2019 •
edited
Loading

Breaking

  • Removed loadInventory
  • Removed loadUserInventory
  • Removed getReceivedItems
  • Removed TradeOffer#loadPartnerInventory
  • Node.js v8 or later is now required

New

  • Trade sessions
  • Promise support

To Do

  • Test everything
  • Write docs
  • Update examples

DoctorMcKay and others added 30 commits November 5, 2017 01:58
@DoctorMcKay
Require node v6 or later
9e1815f
@DoctorMcKay
Use @doctormckay/stdlib for LeastUsedCache
f223628
@DoctorMcKay
Added TradeSession
aafce94
@DoctorMcKay
RIP automatic offer-getting once confirmed
3f5a629
@DoctorMcKay
Added jsdoc
c7037ee
@DoctorMcKay
var -> let
f4d2b43
@DoctorMcKay
Cleaned up some unused constants
e369f61
@DoctorMcKay
Clean up self = this type stuff
44ce958
@DoctorMcKay
Consolidate callback of getExchangeDetails into a single object
5a6dad6
@DoctorMcKay
Updated functions in index.js to use promises
16106d1
@DoctorMcKay
Fixed promise not returned
57998d4
@DoctorMcKay
Removed loadInventory and loadUserInventory
8bc69ea
@DoctorMcKay
Revert "Consolidate callback of getExchangeDetails into a single object"
9d80442 
This reverts commit 5a6dad6
@DoctorMcKay
Added node 6 requirement to breaking list
c87cc13
@DoctorMcKay
Throw an Error if someone tries to create a TradeOffer with a number …
db80d17 
…SteamID
@DoctorMcKay
Merge branch 'master' into v3
8c12125
@DoctorMcKay
Add items to itemsToGive immediately but with a pendingAdd property
1fa17fa
@DoctorMcKay
Update version number
f0ca177
@DoctorMcKay
Don't include pendingAdd items when auditing item count
259887d
@DoctorMcKay
Immediately remove items from itemsToGive
76d6592
@DoctorMcKay
Check _itemsToGiveRemoving when we audit the trade
bdd6d38
@DoctorMcKay
Spoof events if necessary to keep trade in sync
f76509f
@DoctorMcKay
Don't forget to resolve promise for our own chat messages
5ee4910
@DoctorMcKay
Also spoof AddItem events for our own items
7ba9754
@DoctorMcKay
Merge branch 'master' into v3
f78db0d 
# Conflicts:
#	lib/index.js
#	package.json
@DoctorMcKay
Removed async dependency
63a92c3
@DoctorMcKay
Removed deep-equal dependency
95e4162
@DoctorMcKay
Merge branch 'master' into v3
a7c0262 
# Conflicts:
#	lib/index.js
#	lib/webapi.js
#	package.json
@DoctorMcKay
Disable trade session support for v3 release
4c3373b
@DoctorMcKay
Added jsdoc
0149013
@DoctorMcKay DoctorMcKay linked an issue Mar 29, 2021 that may be closed by this pull request
Add Promise support #185
Open
@DoctorMcKay DoctorMcKay mentioned this pull request Apr 7, 2021
Closed
@Newbrict
Copy link

Newbrict commented Apr 9, 2023

Is this still in development?

@kanehjeong
Copy link

@DoctorMcKay Do you have a timeline of when the above will be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Promise support
3 participants
@DoctorMcKay @Newbrict @kanehjeong